Awesome Privacy

Recent Commits

• Tobias Eigen (29 Mar 24)

  Improved description of `allow_anonymous_likes` (#26269) improved description of `allow_anonymous_likes` setting so it no longer refers to not-logged-in-users

• Tobias Eigen (29 Mar 24)

  update desc of personal message enabled groups setting (#26296) The personal message enabled groups site setting is overridden by the group interaction settings for specifying who is allowed to write to groups. This was not clearly explained in the description here and I think I fixed it!

• Tobias Eigen (29 Mar 24)

  removed link to TOS from community guidelines (#26326) Not all sites will want to have a terms of service page, so we do not want to link to it from the community guidelines.

• dependabot[bot] (28 Mar 24)

  Build(deps): Bump @glimmer/syntax from 0.91.0 to 0.91.1 (#26428) Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.91.0 to 0.91.1. - [Release notes](https://github.com/glimmerjs/glimmer-vm/releases) - [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md) - [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.91.0...v0.91.1) --- updated-dependencies: - dependency-name: "@glimmer/syntax" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• dependabot[bot] (28 Mar 24)

  Build(deps-dev): Bump glob from 10.3.10 to 10.3.12 (#26429) Bumps [glob](https://github.com/isaacs/node-glob) from 10.3.10 to 10.3.12. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](https://github.com/isaacs/node-glob/compare/v10.3.10...v10.3.12) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• Penar Musaraj (28 Mar 24)

  DEV: Add `{{hide-application-sidebar}}` helper (#26310)

• Kris (28 Mar 24)

  UX: wrap `small-user-list-content` for many users case (#26422)

• Bianca Nenciu (28 Mar 24)

  DEV: Better categories pagination (#26421) Pagination is enabled only when "lazy load categories" is enabled. For those cases when it is not, the first page should return all the results.

• Daniel Waterworth (28 Mar 24)

  DEV: Make CategoryChooser optionally provide the category (#26420) ... rather than just the category id. In order for the user to have selected a category, the category must have been loaded and it's useful for the category chooser to provide this fetched category so that it doesn't need to be refetched. In the future, it would be better to store the categories that the chooser knows about in local component state, so that the category doesn't need to be fetched from the id map, but this, at least, puts the API in place.

• Kris (28 Mar 24)

  FIX: use getter for `showPoweredBy` (#26419)

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Change group type to groups type for theme object schema (#26417) Why this change? This is a follow-up to 86b2e3a. Basically, we want to allow people to select more than 1 group as well. What does this change do? 1. Change `type: group` to `type: groups` and support `min` and `max` validations for `type: groups`. 2. Fix the `<SchemaThemeSetting::Types::Groups>` component to support the `min` and `max` validations and switch it to use the `<GroupChooser>` component instead of the `<ComboBoxComponent>` component which previously only supported selecting a single group.

• dependabot[bot] (28 Mar 24)

  Build(deps-dev): Bump selenium-webdriver from 4.18.1 to 4.19.0 (#26405) Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.18.1 to 4.19.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.18.1...selenium-4.19.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Rewrite `SchemaThemeSetting::Editor` to avoid rerendering problems (#26416) Why this change? Prior to this change, the `SchemaThemeSetting::Editor#tree` was creating a new `Tree` instance which holds instances of `Node`. Both classes consisted of tracked properties. The problem with this approach is that when any tracked properties is updated, Ember will revaluate `SchemaThemeSetting::Editor#tree` and because that method always return a new instance of `Tree`, it causes the whole navigation tree to rerender just because on tracked property changed. This rerendering of the whole navigation tree every time made it hard to implement simple features like hiding a section in 9baa820d53757aec36e4cb86efab8d0bb3f264c0. Instead of being able to just declare a tracked property to hide/show a section, we end up with a more complicated solution. This commit rewrites `SchemaThemeSetting::Editor` to depend on Ember components to form the tree structure instead. As needed, each component in the tree structure can declare its own tracked property as necessary.

• Martin Brennan (28 Mar 24)

  DEV: Add missing belongs_to to UserAction model (#26415)

• Ted Johansson (28 Mar 24)

  DEV: Make problem check registration more explicit (#26413) Previously the problem check registry simply looked at the subclasses of ProblemCheck. This was causing some confusion in environments where eager loading is not enabled, as the registry would appear empty as a result of the classes never being referenced (and thus never loaded.) This PR changes the approach to a more explicit one. I followed other implementations (bookmarkable and hashtag autocomplete.) As a bonus, this now has a neat plugin entry point as well.

• Martin Brennan (28 Mar 24)

  FIX: Hide footgun max_notifications_per_user site setting (#26414) It's not really intentional to have regular admins change this in all but pathological cases. It deletes all notifications over this threshold for users without warning. If admins really want to turn this on, they can do it via the app.yml file

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Support translations for property labels in objects schema editor (#26362) Why this change? In cdba86459877987f52def4bcfeba5c7bef7de407, we added support for adding a description which will be displayed under the input of each property on the client side. Currently this convention in the locale file is followed: ``` en: theme_metadata: settings: objects_setting: description: <description> for the setting schema: properties: name: <description for the name property> links: name: <description for the name property in link> url: <description for the url property in link> ``` Since we now want to allow the label to be translated as well, we will be changing the convention to the following: ``` en: theme_metadata: settings: objects_setting: description: <description> for the setting schema: properties: name: label: <label for the name property> description: <description for the name property> links: name: label: <label for the name property> description: <description for the name property in link> url: label: <label for the url property> description: <description for the url property in link> ``` If the locale file does not provide a `label` key under the property's name, the client side will just display the property's name as the label for the input field.

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Update actions cache keys for bundler cache take 2 (#26411) This is a follow up to 69c132723ff7cf1c338709ac658b919c9f984125 which wasn't right and broke our bundler github actions cache key

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Add a test to ensure that our SMTP settings are correct (#26410) Why this change? This is a follow up to 897be75941eb95b89e885e4b447ddf0c75eb81ff. When updating `net-smtp` from `0.4.x` to `0.5.x`, our test suite passed but the error `ArgumentError: SMTP-AUTH requested but missing user name` was being thrown in production leading to emails being failed to send out via SMTP. This commit adds a test to ensure that our production SMTP settings will at least attemp to connect to an SMTP server.

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Update actions cache keys for bundler and app cache (#26398) Why this change? Bundle cache should be keyed on ruby version as well as the debian release name. Changes to the debian release can affect the way gems are installed since gems may link to different versions of binaries.

• dependabot[bot] (28 Mar 24)

  Build(deps-dev): Bump selenium-devtools from 0.122.0 to 0.123.0 (#26406) Bumps [selenium-devtools](https://github.com/SeleniumHQ/selenium) from 0.122.0 to 0.123.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits) --- updated-dependencies: - dependency-name: selenium-devtools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• Alan Guo Xiang Tan (28 Mar 24)

  DEV: Drop unused cloud66 configuration files (#26409) Why this change? These files were added 10 years ago and are no longer maintained or relevant. Please see https://github.com/discourse/discourse/blob/main/docs/INSTALL-cloud.md instead.

• dependabot[bot] (27 Mar 24)

  Build(deps): Bump google-protobuf from 4.26.0 to 4.26.1 (#26407) Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 4.26.0 to 4.26.1. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: google-protobuf dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• dependabot[bot] (27 Mar 24)

  Build(deps): Bump terser from 5.29.2 to 5.30.0 (#26404) Bumps [terser](https://github.com/terser/terser) from 5.29.2 to 5.30.0. - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v5.29.2...v5.30.0) --- updated-dependencies: - dependency-name: terser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• Sérgio Saquetim (27 Mar 24)

  DEV: Extract the query code from CategoryList.find_relevant_topics into a separate method (#26390) ## Why this change? The previous implementation of the method generated the query to find the relevant topics and iterated over the results, processing them. This behavior made difficult reusing or changing the query logic in classes extending `CategoryList`. This commit extracts the query logic into another method called `relevant_topics_query ` which can be reused or overwritten in descendant classes.

• dependabot[bot] (27 Mar 24)

  Build(deps): Bump net-smtp from 0.4.0.1 to 0.5.0 (#26381) Bumps [net-smtp](https://github.com/ruby/net-smtp) from 0.4.0.1 to 0.5.0. - [Release notes](https://github.com/ruby/net-smtp/releases) - [Changelog](https://github.com/ruby/net-smtp/blob/master/NEWS.md) - [Commits](https://github.com/ruby/net-smtp/compare/v0.4.0.1...v0.5.0) --- updated-dependencies: - dependency-name: net-smtp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

• Daniel Waterworth (27 Mar 24)

  FIX: Don't set smtp authentication type when there's no user or password ... otherwise net-smtp, starting with 0.5.0, complains.

• Michael Brown (27 Mar 24)

  Revert "Build(deps): Bump net-smtp from 0.4.0.1 to 0.5.0 (#26381)" (#26402) This reverts commit 260b2a7450f75646f7c659ef41fa004ae51ec54d. I believe this is causing errors: `SMTP-AUTH requested but missing user name`

• Joffrey JAFFEUX (27 Mar 24)

  FIX: tweaks of select-kit on mobile (#26401) - uses footer-nav height and safe-area-inset-bottom as bottom padding - body scroll lock select-kit only when inside a modal

• Joffrey JAFFEUX (27 Mar 24)

  FIX: prevents body scroll to hide sticky elements (#26400) Applying `overflow: hidden` was not playing well with sticky elements (like the header for example). It appears that we don't really need this to achieve our goal so Im removing this part of body scroll lock for now.